Fix wildcard application-identifier in entitlement #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provisioning profile defines a list of supported entitlements which may include wildcard identifiers. The actual application entitlement should not contain any wildcards. This results in bugs such as broken file import on iOS 14. This patch only fixes wildcards in application-identifier. It does not fix any other keys. It does not support wildcards except '*'. As part of the change, the feature to remove get-task-allow is also moved to unify the entitlement modification code.
Jmilby2187
approved these changes
Nov 13, 2020
|
Thanks a lot for the fix! Until this PR get merged, here is a fork with the fix applied and prebuilt binaries via GitHub CI: https://github.com/ViRb3/ios-app-signer |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provisioning profile defines a list of supported entitlements which may
include wildcard identifiers. The actual application entitlement should not
contain any wildcards. This results in bugs such as broken file import on
iOS 14.
This patch only fixes wildcards in application-identifier. It does not fix
any other keys. It does not support wildcards except '*'.
As part of the change, the feature to remove get-task-allow is also moved to
unify the entitlement modification code.
See utmapp/UTM#519 for more details on the issue.