-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automating the creation of the uBlock Origin version of the ClearURLs list #326
Conversation
[Bot] Update the list ClearURLs uBo list
[Bot] Update the list ClearURLs uBo list
What just happened? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct (can't say to much about the workflow). I'm not sure how strict you are about code styling, so fell free to ignore the suggestions below.
Fix the styling Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
I assume that you are ok with me copying your code? |
Absolutely, arkenfox/user.js#1263 (comment):
|
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Okay, so I feel like this is proceeding way too fast, to the point I feel I'm beginning to lose control of the situation. Off the top of my head, one option I'd be more comfortable with, would be if it was possible to place the three files in the same folder, so their filepaths become e.g. I also think the metadata of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested try to generated the head.
ClearURLs Converter/generate_clearurlsubo.yml
The workflow must be in .github/workflows
.
The YML can’t be in the same folder, it has to be in the .github/workflows folder. I could put both the script and output in a new folder, but that would break it for anyone who used the list. Maybe the script should go in the folder with the output like the alternate versions of the antimalware list
I’m working on that, it just was late yesterday so I had to stop & continue today |
Fair point. I thus give my approval to keeping it in
Since the list is currently not listed on FilterLists.com, I presume we can change its folder and thus URL this time around. |
https://help.eyeo.com/adblockplus/how-to-write-filters
Does anyone know if this this is supported by µBlock origin? |
To my knowledge, the only people who have subscribed to it is me, @kah0922, and maybe @rusty-snake |
No: https://github.com/DandelionSprout/adfilt/blob/master/Wiki/SyntaxMeaningsThatAreActuallyHumanReadable.md#adblock-plus-and-adblock-only We could make a post on #163 though |
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
@DandelionSprout would you rather a PR or just a direct commit |
Weirdly, some commits appear in one branch and others in another |
PR, mostly because I need to handle vacuum cleaning and similar cleaning before I can tend to this in detail. |
Ok. I think I need to close this PR and open a new one, because GH is making it impossible to use this one |
Ok. Closing this in favor of #327 |
It creates a PR, but I can have it just push to the repo
CCing @rusty-snake @DandelionSprout