Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PID-Profiles (#145)" #160

Merged
merged 1 commit into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ If I want my printer to light itself on fire, I should be able to make my printe

- [core: no Python2 tests; no PRU boards](https://github.com/DangerKlippers/danger-klipper/pull/39)

- [core: git-untracked folder, plugins for user-plugins](https://github.com/DangerKlippers/danger-klipper/pull/82)

- [core: danger_options](https://github.com/DangerKlippers/danger-klipper/pull/67)

- [fan: normalising Fan PWM power](https://github.com/DangerKlippers/danger-klipper/pull/44) ([klipper#6307](https://github.com/Klipper3d/klipper/pull/6307))

- [fan: reverse FAN](https://github.com/DangerKlippers/danger-klipper/pull/51) ([klipper#4983](https://github.com/Klipper3d/klipper/pull/4983))
Expand All @@ -26,8 +22,6 @@ If I want my printer to light itself on fire, I should be able to make my printe

- [heater: velocity PID](https://github.com/DangerKlippers/danger-klipper/pull/47) ([klipper#6272](https://github.com/Klipper3d/klipper/pull/6272))

- [heater: PID-Profiles](https://github.com/DangerKlippers/danger-klipper/pull/145)

- [gcode: jinja2.ext.do extension](https://github.com/DangerKlippers/danger-klipper/pull/26) ([klipper#5149](https://github.com/Klipper3d/klipper/pull/5149))

- [gcode: gcode_shell_command](https://github.com/DangerKlippers/danger-klipper/pull/26) ([klipper#2173](https://github.com/Klipper3d/klipper/pull/2173) / [kiuah](https://github.com/dw-0/kiauh/blob/master/resources/gcode_shell_command.py) )
Expand All @@ -40,20 +34,20 @@ If I want my printer to light itself on fire, I should be able to make my printe

- [z_tilt: z-tilt calibration](https://github.com/DangerKlippers/danger-klipper/pull/105) ([klipper3d#4083](https://github.com/Klipper3d/klipper/pull/4083) / [dk/ztilt_calibration](https://github.com/DangerKlippers/danger-klipper/pull/54))

- [stepper: home_current](https://github.com/DangerKlippers/danger-klipper/pull/65)
- [core: danger_options](https://github.com/DangerKlippers/danger-klipper/pull/67)

- [stepper: current_change_dwell_time](https://github.com/DangerKlippers/danger-klipper/pull/90)
- [stepper: home_current](https://github.com/DangerKlippers/danger-klipper/pull/65)

- [homing: post-home retract](https://github.com/DangerKlippers/danger-klipper/pull/65)

- [homing: sensorless minimum home distance](https://github.com/DangerKlippers/danger-klipper/pull/65)

- [homing: min_home_dist](https://github.com/DangerKlippers/danger-klipper/pull/90)

- [virtual_sdcard: scanning of subdirectories](https://github.com/DangerKlippers/danger-klipper/pull/68) ([klipper#6327](https://github.com/Klipper3d/klipper/pull/6327))

- [retraction: z_hop while retracting](https://github.com/DangerKlippers/danger-klipper/pull/83) ([klipper#6311](https://github.com/Klipper3d/klipper/pull/6311))

- [core: git-untracked folder, plugins for user-plugins](https://github.com/DangerKlippers/danger-klipper/pull/82)

- [danger_options: allow plugins to override conflicting extras](https://github.com/DangerKlippers/danger-klipper/pull/82)

- [danger_options: expose the multi mcu homing timeout as a parameter](https://github.com/DangerKlippers/danger-klipper/pull/93)
Expand All @@ -64,6 +58,10 @@ If I want my printer to light itself on fire, I should be able to make my printe

- [temperature_mcu: add reference_voltage](https://github.com/DangerKlippers/danger-klipper/pull/99) ([klipper#5713](https://github.com/Klipper3d/klipper/pull/5713))

- [stepper: current_change_dwell_time](https://github.com/DangerKlippers/danger-klipper/pull/90)

- [homing: min_home_dist](https://github.com/DangerKlippers/danger-klipper/pull/90)

- [adxl345: improve ACCELEROMETER_QUERY command](https://github.com/DangerKlippers/danger-klipper/pull/124)

- [extruder: add flag to use the PA constant from a trapq move vs a cached value](https://github.com/DangerKlippers/danger-klipper/pull/132)
Expand Down
54 changes: 0 additions & 54 deletions docs/G-Codes.md
Original file line number Diff line number Diff line change
Expand Up @@ -757,14 +757,6 @@ above the supplied MINIMUM and/or at or below the supplied MAXIMUM.
[TARGET=<target_temperature>]`: Sets the target temperature for a
heater. If a target temperature is not supplied, the target is 0.

#### SET_SMOOTH_TIME
`SET_SMOOTH_TIME HEATER=<heater_name> [SMOOTH_TIME=<smooth_time>]
[SAVE_TO_PROFILE=0|1]`: Sets the smooth_time of the specified heater.
If SMOOTH_TIME is omitted, the smooth_time will be reset to the value
from the config.
If SAVE_TO_PROFILE is set to 1, the new value will be written to the
current PID_PROFILE.

### [idle_timeout]

The idle_timeout module is automatically loaded.
Expand Down Expand Up @@ -976,52 +968,6 @@ require a value of 0.03 or higher.
allow one to manually change PID parameters of heaters without a
reload of the firmware.

### [pid_profile]

The PID_PROFILE module is automatically loaded if a heater is defined
in the config file.

#### PID_PROFILE
`PID_PROFILE LOAD=<profile_name> HEATER=<heater_name> [DEFAULT=<profile_name>]
[VERBOSE=<verbosity>] [RESET_TARGET=0|1] [LOAD_CLEAN=0|1]`:
Loads the given PID_PROFILE for the specified heater. If DEFAULT is specified,
the Profile specified in DEFAULT will be loaded when then given Profile for LOAD
can't be found (like a getOrDefault method). If VERBOSE is set to LOW, minimal
info will be written in console.
If set to NONE, no console outputs will be given.
If KEEP_TARGET is set to 1, the heater will keep it's target temperature,
if set to 0, the target temperature will be set to 0.
By default the target temperature of the heater will be set to 0 so the
algorithm has time to settle in.
If LOAD_CLEAN is set to 1, the profile would be loaded as if the printer just
started up, if set to 0, the profile will retain previous heating information.
By default the information will be kept to reduce overshoot, change this value
if you encounter weird behaviour while switching profiles.

`PID_PROFILE SAVE=<profile_name> HEATER=<config_name>`:
Saves the currently loaded profile of the specified heater to the config under
the given name.

`PID_PROFILE REMOVE=<profile_name> HEATER=<config_name>`:
Removes the given profile from the profiles List for the current session and config if SAVE_CONFIG is issued afterwards.

`PID_PROFILE SET_VALUES=<profile_name> HEATER=<heater_name> TARGET=<target_temp> TOLERANCE=<tolerance>
CONTROL=<control_type> KP=<kp> KI=<ki> KD=<kd> [RESET_TARGET=0|1] [LOAD_CLEAN=0|1]`:
Creates a new profile with the given PID values, CONTROL must either be `pid` or
`pid_v`, TOLERANCE and TARGET must be specified to create a valid profile,
though the values themselves don't matter.
If KEEP_TARGET is set to 1, the heater will keep it's target temperature,
if set to 0, the target temperature will be set to 0.
By default the target temperature of the heater will be set to 0 so the
algorithm has time to settle in.
If LOAD_CLEAN is set to 1, the profile would be loaded as if the printer just
started up, if set to 0, the profile will retain previous heating information.
By default the information will be kept to reduce overshoot, change this value
if you encounter weird behaviour while switching profiles.

`PID_PROFILE GET_VALUES HEATER=<heater_name>`:
Outputs the values of the current loaded pid_profile of the given heater to the console.

### [pause_resume]

The following commands are available when the
Expand Down
Loading
Loading