fix(build): output assembly file with .S for preprocessing
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html This is important for aarch64 which uses __SIZEOF_POINTER__ & __AARCH64EB__ that require preprocessing.
This was referenced Aug 5, 2024
|
Good job! |
3 tasks
ferranbt
pushed a commit
to flashbots/rbuilder
that referenced
this pull request
Sep 30, 2024
## 📝 Summary This updates sha3-asm / keccak-asm deps. ## 💡 Motivation and Context `0.1.4` includes fixes which make keccak-asm work on more platforms (DaniPopes/keccak-asm#5) --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
astarinmymind
pushed a commit
to flashbots/rbuilder
that referenced
this pull request
Oct 3, 2024
## 📝 Summary This updates sha3-asm / keccak-asm deps. ## 💡 Motivation and Context `0.1.4` includes fixes which make keccak-asm work on more platforms (DaniPopes/keccak-asm#5) --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html
This is important for aarch64 which uses
__SIZEOF_POINTER__&__AARCH64EB__that require preprocessing.Closes #2
Fixes #4