Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive constraint keys break with v1.1.8 #38

Closed
boerbiet opened this issue Jan 14, 2015 · 3 comments
Closed

Case sensitive constraint keys break with v1.1.8 #38

boerbiet opened this issue Jan 14, 2015 · 3 comments

Comments

@boerbiet
Copy link

Creating an issue from my comment, by request.

I found out the change in 1.1.8 (Ignore case of controller, action, area, and keys of parameters) breaks some functionality on our site after a colleague updated from 1.1.7 to 1.1.8. For example:

C#

routes.MapRoute("Arbitrary Route", "path/{variableThing}/etc/", new { controller = "X", action = "Y" }, new { variableThing = "Z" });

JS

Router.Action('X', 'Y', { variableThing: 'Z' });

Now when the constraints are parsed, the key variable will be "variableThing". The objects however:

parsedConstraints['variableThing'] = /^(Z)/

routevalues['variablething'] = 'Z'

Due to the lower case key the route will not match.

@Daniel15
Copy link
Owner

Can you please try the latest build and let me know if it resolves your particular issue? You can get packages from the build server at http://teamcity.codebetter.com/viewLog.html?buildId=178515&tab=artifacts&buildTypeId=routejs&guest=1

@boerbiet
Copy link
Author

I can confirm that the ajax controls that stopped working with 1.1.8 are working again with 1.1.9-dev.

@Daniel15
Copy link
Owner

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants