Add FFAA and tweak styling #19
Conversation
✅ Deploy Preview for daniel-herr-software ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @DanielHerr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the website's content by integrating a new section dedicated to 'Web Sites,' prominently featuring the 'FF Apps Archive.' Concurrently, it refines the site's visual presentation through targeted CSS adjustments, ensuring consistent image alignment and link styling. The changes also standardize the structure of link text across various sections by encapsulating it within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for daniel-herr-software-forms ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Visit the preview URL for this PR (updated for commit 866dbc8): https://daniel-herr-software--pr19-dev-8hd7aol3.web.app (expires Thu, 13 Nov 2025 05:51:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8c152685cc1a60c2381e223a321e638cf5e1d307 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new 'Web Sites' section featuring the 'FF Apps Archive', and also adds a Telegram link to the contact section. The styling for links has been updated to underline only the text portion. The changes are generally good, but I've identified a security issue with the new external links, which are missing rel="noopener noreferrer". I've also left a comment on the new CSS rules regarding their global scope, which could have unintended side effects on other links.
| <a href="https://t.me/Daniel_Herr"> | ||
| <img src="https://telegram.org/img/favicon-32x32.png" alt="" width="16" height="16"> | ||
| <span>Telegram</span> | ||
| </a> |
There was a problem hiding this comment.
This new external link is missing the rel="noopener noreferrer" attribute for security. It's also a good practice to open external links in a new tab using target="_blank".
| <a href="https://t.me/Daniel_Herr"> | |
| <img src="https://telegram.org/img/favicon-32x32.png" alt="" width="16" height="16"> | |
| <span>Telegram</span> | |
| </a> | |
| <a href="https://t.me/Daniel_Herr" rel="noopener noreferrer" target="_blank"> | |
| <img src="https://telegram.org/img/favicon-32x32.png" alt="" width="16" height="16"> | |
| <span>Telegram</span> | |
| </a> |
| a { | ||
| display: inline-block; | ||
| text-decoration: none; | ||
| } | ||
| a span { | ||
| text-decoration: underline; | ||
| } |
There was a problem hiding this comment.
These new global styles for <a> and a span will affect all links on the site. Specifically, text-decoration: none; on a and text-decoration: underline; on a span means that any link text not wrapped in a <span> will no longer be underlined. For example, the 'Support' link on the page will now appear without an underline, which might not be intended. To make these styles more robust and avoid unintended side effects, consider making the selectors more specific (e.g., by adding a class to the targeted links) or ensure all link texts that should be underlined are wrapped in a <span>.
Deploying daniel-herr-software with
|
| Latest commit: |
866dbc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e591390f.daniel-herr-software.pages.dev |
| Branch Preview URL: | https://dev.daniel-herr-software.pages.dev |
No description provided.