feat: add inject(head|body) and minify options to safari10NoModuleFix #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
despian
commented
Feb 15, 2020
despian
commented
- maintains compatibility with the previous option format
- minify defaults to false to maintain compatibility with old format
|
I'm using this plugin in a project which outputs a partial HTML file. So I needed the ability to insert the fix into the body, not in the head. I also added a minification option because it seemed like a good idea. |
DanielSchaffer
requested changes
Feb 15, 2020
despian
force-pushed
the
feature/safarifix-inject-option
branch
from
72bd347
to
eb9f417
Compare
DanielSchaffer
approved these changes
Mar 10, 2020
|
Available in prerelease v2.5.0-next.2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.