Cleanup Bun loader code #1291
Merged
Cleanup Bun loader code #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify example to include TypeScript type notation, for testing * Use Bun's file interface instead of Node compatibility layer * Use braced object notation for cleaner methods * Commented out code for manual transpilation of JSX (doesn't work yet)
STRd6
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an attempt at #1286, but the Transpiler doesn't actually seem to work as desired (need to manually specify
tsconfig, and even then, it doesn't seem to add the implicitimport, and the result behaves weird if the module has noimport/export). But the cleanup was a moderate improvement, so I'm submitting that: