Lexical declarations as JSX code children #1387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more idea from #561: This PR allows for lexical declarations as JSX code children (as braced expressions,
>
expressions, or automatic code children). In particular, this example now works:Somewhat unusual for Civet is that the declaration is not treated as an expression, as that would cause it to render in the JSX, which seems rarely desired. Instead we automatically add
,void 0
at the end to prevent rendering and just do the assignment. The declaration itself gets lifted (though there's no way to preserveconst
semantics here).