Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Belarusian translation language #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Belarusian translation language #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Translumo.Infrastructure/Language/LanguageDescriptorFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public IEnumerable<LanguageDescriptor> GetAll()
new LanguageDescriptor() { Language = Languages.Arabic, Code = "ar-SA", IsoCode = "ar", TranslationOnly = true },
new LanguageDescriptor() { Language = Languages.Greek, Code = "el-GR", IsoCode = "el", TranslationOnly = true },
new LanguageDescriptor() { Language = Languages.PortugueseBrazil, Code = "pt-BR", IsoCode = "pt", TranslationOnly = true, RegionalVariant = true },
new LanguageDescriptor() { Language = Languages.Belarusian, Code = "be-BY", IsoCode = "be", TranslationOnly = true },
};
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/Translumo.Infrastructure/Language/Languages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public enum Languages : byte
Thai = 12,
Arabic = 13,
Greek = 14,
PortugueseBrazil = 15
PortugueseBrazil = 15,
Belarusian = 16,
}
}
10 changes: 7 additions & 3 deletions src/Translumo.Translation/Deepl/DeeplTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ public sealed class DeepLTranslator : BaseTranslator<DeeplContainer>
{
private const string DEEPL_API_URL = "https://www2.deepl.com/jsonrpc";

private readonly HashSet<Languages> _unsupportedLanguages = new(new[]
{
Languages.Vietnamese, Languages.Thai, Languages.Arabic, Languages.Belarusian
});

public DeepLTranslator(TranslationConfiguration translationConfiguration, LanguageService languageService, ILogger logger)
: base(translationConfiguration, languageService, logger)
{
Expand All @@ -27,10 +32,9 @@ public DeepLTranslator(TranslationConfiguration translationConfiguration, Langua
public override Task<string> TranslateTextAsync(string sourceText)
{
//TODO: Temp implementation for specific lang
if (TargetLangDescriptor.Language == Languages.Vietnamese
|| TargetLangDescriptor.Language == Languages.Thai || TargetLangDescriptor.Language == Languages.Arabic)
if (_unsupportedLanguages.Contains(TargetLangDescriptor.Language))
{
throw new TransactionException("DeepL translator for this language is unavailable");
throw new TransactionException("DeepL translator is unavailable for this language");
}

return base.TranslateTextAsync(sourceText);
Expand Down
2 changes: 1 addition & 1 deletion src/Translumo.Translation/Papago/PapagoTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public sealed class PapagoTranslator : BaseTranslator<PapagoContainer>
private readonly AutoResetEvent _sync;
private readonly HashSet<Languages> _unsupportedLanguages = new(new[]
{
Languages.Turkish, Languages.Arabic, Languages.PortugueseBrazil, Languages.Greek
Languages.Turkish, Languages.Arabic, Languages.PortugueseBrazil, Languages.Greek, Languages.Belarusian
});

public PapagoTranslator(TranslationConfiguration translationConfiguration, LanguageService languageService, ILogger logger) :
Expand Down
1 change: 1 addition & 0 deletions src/Translumo/Resources/Localization/lang.en-US.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
<system:String x:Key="Str.Languages.Arabic">Arabic</system:String>
<system:String x:Key="Str.Languages.Greek">Greek</system:String>
<system:String x:Key="Str.Languages.PortugueseBrazil">Portuguese (BR)</system:String>
<system:String x:Key="Str.Languages.Belarusian">Belarusian</system:String>

<!--Dialog stages-->
<system:String x:Key="Str.Stages.CheckPyModules">Checking installed modules...</system:String>
Expand Down
1 change: 1 addition & 0 deletions src/Translumo/Resources/Localization/lang.ru-RU.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
<system:String x:Key="Str.Languages.Arabic">Арабский</system:String>
<system:String x:Key="Str.Languages.Greek">Греческий</system:String>
<system:String x:Key="Str.Languages.PortugueseBrazil">Португальский (бразильский)</system:String>
<system:String x:Key="Str.Languages.Belarusian">Белорусский</system:String>

<!--Dialog stages-->
<system:String x:Key="Str.Stages.CheckPyModules">Проверка установленных модулей...</system:String>
Expand Down