Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with non zero code when showing usage #36

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Exit with non zero code when showing usage #36

merged 2 commits into from
Oct 3, 2018

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Oct 3, 2018

This PR exits with code 1 instead of 0 when run ends up showing usage pattern or help (anything that raises Docopt::Exit).

This is compatible with other linux commands, and the rationale is this:

If you are running any run command in a situation where the exit code matters (for example, to run tests on CI), then in case you mistyped the command, the exit code will represent success instead of failure.

@DannyBen DannyBen merged commit 8bea0f1 into master Oct 3, 2018
@DannyBen DannyBen deleted the exitcode branch October 3, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant