Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hoppers being able to steal Items out of locked Containers #1391

Closed
3 of 12 tasks
ethernia-root opened this issue Apr 16, 2022 · 2 comments
Closed
3 of 12 tasks

Fix Hoppers being able to steal Items out of locked Containers #1391

ethernia-root opened this issue Apr 16, 2022 · 2 comments
Assignees
@Kyrenic
Labels
bug Something isn't working
Milestone
5.0.6

Comments

@ethernia-root
Copy link

ethernia-root commented Apr 16, 2022 •
edited by dmccoystephenson
Loading

Describe the bug

Locked Containers are able to be emptied by using Hoppers

To Reproduce

Place Hopper below a locked Container

Expected behavior

Hoppers should not be able to pull Items out of a locked container

Screenshots or Logs

https://imgur.com/a/6Q9ScaE (Container is locked)
https://imgur.com/a/AnIZXaQ (I am pulling Items)

Java version

  • Java 8
  • Java 11
  • Java 16
  • Java 17

Plugin version

  • v4.1
  • v4.2
  • v4.3
  • v4.4
  • v4.5.x

Paper version

  • 1.16.x
  • 1.17.x
  • 1.18.x
@ethernia-root ethernia-root changed the title Bug Report Fix Hoppers being able to steal Items out of locked Containers Apr 16, 2022
@dmccoystephenson dmccoystephenson added bug Something isn't working priority labels Apr 16, 2022
@dmccoystephenson
Copy link
Member

Thanks for letting us know about this!

@dmccoystephenson dmccoystephenson added this to the 4.7.0 milestone Dec 3, 2022
@renbinden renbinden added MF 5 and removed MF 4 labels Dec 13, 2022
@renbinden renbinden modified the milestones: 4.7.0, 5.1.0 Dec 13, 2022
@dmccoystephenson dmccoystephenson modified the milestones: 5.1.0, 5.0.6 Dec 15, 2022
@Kyrenic
Copy link
Contributor

Kyrenic commented Dec 16, 2022

This event would probably apply to hoppers taking items from chests: InventoryMoveItemEvent

@Kyrenic Kyrenic self-assigned this Dec 16, 2022
renbinden added a commit that referenced this issue Dec 19, 2022
@renbinden
Check locked state of source inventory, closes #1391
32efe0a
dmccoystephenson added a commit that referenced this issue Dec 19, 2022
@dmccoystephenson
Merge pull request #1658 from Dans-Plugins/bugfix/hoppers
08ad5d5 
Prevent items from being taken from locked containers by hoppers, closes #1391
renbinden pushed a commit that referenced this issue Dec 19, 2022
@Kyrenic @renbinden
Prevent hoppers from picking up items from locked chests, closes #1391
48a88e0
dmccoystephenson added a commit that referenced this issue Dec 19, 2022
@dmccoystephenson
Merge pull request #1659 from Dans-Plugins/bugfix/hoppers
f395236 
Prevent hoppers from picking up items from locked chests, closes #1391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kyrenic Kyrenic

Labels
bug Something isn't working
Projects
None yet
Milestone
5.0.6
Development

No branches or pull requests
4 participants
@renbinden @dmccoystephenson @Kyrenic @ethernia-root