Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NullCheck for coord1 and coord2 #1502

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Added NullCheck for coord1 and coord2 #1502

merged 2 commits into from
Oct 7, 2022

Conversation

ConfusedAlex
Copy link

See #1501

@dmccoystephenson dmccoystephenson linked an issue Aug 26, 2022 that may be closed by this pull request
Fix error: "this.coord1" is null #1501
Closed
13 tasks
@ConfusedAlex
Copy link
Author

When one of those coords is null, should the whole gate be deleted?

@renbinden
Copy link
Member

We're having a broader discussion on how these get to be null and what the meaning of null is in the Discord.

If they should be null, and that carries meaning, we need to add some logic around handling them when they're not present to the deserialization code also.

If they shouldn't be null, we need to determine how they are getting to be null in the first place and fix the situation occurring.

@dmccoystephenson
Copy link
Member

Regardless, we should add logic around handling them when they're not present since it's possible for them to be null in older versions.

@dmccoystephenson
Copy link
Member

When one of those coords is null, should the whole gate be deleted?

Maybe! Do you have any input on this? @philbgarner

dmccoystephenson
dmccoystephenson requested changes Sep 15, 2022
View reviewed changes
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can explore why the coordinates are null later. Let's focus on accounting for the possibility that it is null for now.

src/main/java/dansplugins/factionsystem/objects/domain/Gate.java Show resolved Hide resolved
@dmccoystephenson dmccoystephenson self-requested a review October 7, 2022 05:12
@dmccoystephenson dmccoystephenson merged commit 24f2c35 into Dans-Plugins:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmccoystephenson dmccoystephenson dmccoystephenson approved these changes

@renbinden renbinden Awaiting requested review from renbinden

@philbgarner philbgarner Awaiting requested review from philbgarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error: "this.coord1" is null
3 participants
@ConfusedAlex @renbinden @dmccoystephenson