Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Fiefs & Currencies Integration + Startup Parsing Error Fix #1519

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

dmccoystephenson
Copy link
Member

@dmccoystephenson dmccoystephenson commented Sep 16, 2022

Description

All references to fiefs and currencies have been removed in order to resolve some circular dependencies.

Startup Error Fix

I also fixed a startup parsing error, but now I'm experiencing this IO error (#1520) in the console upon executing commands.

[17:57:53 INFO]: ERROR: java.io.IOException: The system cannot find the path specified

This doesn't necessarily have to be resolved by this PR, as it isn't the focus of these changes. I've opened a new issue to track it here: #1520

Reviewers

I've tagged a few community members as optional reviewers for this PR, but no one should feel pressured to give their input if they don't want to or don't have time. That being said, at least one approving review will be required to merge this PR.

@dmccoystephenson dmccoystephenson changed the title Removing Fiefs & Currencies + Startup Error Fix Removing Fiefs & Currencies Integration + Startup Error Fix Sep 16, 2022
@dmccoystephenson
Copy link
Member Author

dmccoystephenson commented Sep 16, 2022

My guess is the IO error is getting printed in the MessageService class on line 32. Here's the relevant code:

    public void createLanguageFile() {
        languageFile = new File(medievalFactions.getDataFolder(), "language.yml");
        if (!languageFile.exists()) {
            medievalFactions.saveResource("language.yml", false);
        }

        language = new YamlConfiguration();
        try {
            language.load(languageFile);
        } catch (IOException | InvalidConfigurationException e) {
            medievalFactions.getLogger().log(Level.WARNING, e.getCause().toString());
        }
    }

@VoChiDanh
Copy link
Contributor

I don't think that code is causing the above error...

@dmccoystephenson
Copy link
Member Author

dmccoystephenson commented Sep 16, 2022

I think you're right @VoChiDanh now that I look at it again the code I posted involves a warning-level log message, rather than an info one in the IO error above.

@dmccoystephenson dmccoystephenson changed the title Removing Fiefs & Currencies Integration + Startup Error Fix Removing Fiefs & Currencies Integration + Startup Parsing Error Fix Sep 16, 2022
Copy link
Member Author

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I'm going to go ahead and merge this PR.

@dmccoystephenson dmccoystephenson merged commit bf45050 into master Sep 22, 2022
@dmccoystephenson dmccoystephenson deleted the removing-fiefs-and-currencies-integration branch September 22, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants