Feature - Disband Other Factions #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
French translations are required for the following: CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. |
renbinden
requested changes
Dec 13, 2022
| if (faction.members.size != 1) { | ||
| sender.sendMessage("$RED${plugin.language["CommandFactionDisbandFactionMustBeEmpty"]}") | ||
| return@Runnable | ||
| else { |
There was a problem hiding this comment.
This should be on the same line as the closing brace
| return@Runnable | ||
| } | ||
|
|
||
| val nameOfFaction = args.joinToString(" "); |
There was a problem hiding this comment.
Needs update to onTabComplete to complete faction names
There was a problem hiding this comment.
Added tab complete (used declare war tab complete).
| @@ -1016,3 +1016,5 @@ FactionDisbandedZeroPowerNotificationBody=Your faction, {0}, was disbanded as it | |||
| Teleporting=Teleporting in {0} seconds... | |||
| TeleportationCancelled=Teleportation cancelled. | |||
| PowerIncreased=You feel stronger. Your power has increased by {0}. | |||
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |||
There was a problem hiding this comment.
Suggested change
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |
| CommandFactionDisbandOthersNoPermission=You don''t have permission to disband other factions. |
| @@ -1016,3 +1016,5 @@ FactionDisbandedZeroPowerNotificationBody=Your faction, {0}, was disbanded as it | |||
| Teleporting=Teleporting in {0} seconds... | |||
| TeleportationCancelled=Teleportation cancelled. | |||
| PowerIncreased=You feel stronger. Your power has increased by {0}. | |||
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |||
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn't found. | |||
There was a problem hiding this comment.
Suggested change
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn't found. | |
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn''t found. |
| @@ -1016,3 +1016,5 @@ FactionDisbandedZeroPowerNotificationBody=Your faction, {0}, was disbanded as it | |||
| Teleporting=Teleporting in {0} seconds... | |||
| TeleportationCancelled=Teleportation cancelled. | |||
| PowerIncreased=You feel stronger. Your power has increased by {0}. | |||
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |||
There was a problem hiding this comment.
Suggested change
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |
| CommandFactionDisbandOthersNoPermission=You don''t have permission to disband other factions. |
| @@ -1016,3 +1016,5 @@ FactionDisbandedZeroPowerNotificationBody=Your faction, {0}, was disbanded as it | |||
| Teleporting=Teleporting in {0} seconds... | |||
| TeleportationCancelled=Teleportation cancelled. | |||
| PowerIncreased=You feel stronger. Your power has increased by {0}. | |||
| CommandFactionDisbandOthersNoPermission=You don't have permission to disband other factions. | |||
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn't found. | |||
There was a problem hiding this comment.
Suggested change
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn't found. | |
| CommandFactionDisbandSpecifiedFactionNotFound=The specified faction wasn''t found. |
|
This is ready for re-review @alyphen |
renbinden
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR allow players to disband other factions if they have permission.
closes #1613