Added unique name check to set name command.
#1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renbinden
approved these changes
May 7, 2023
There was a problem hiding this comment.
This seems adequate for most cases.
It may also be worth adding a unique constraint at the DB level in a migration, as if two players ran the command at exactly the same time, the query to update the faction is run async so both might succeed. That's absolutely an edge case though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking for unique names when a faction was created, but not when it was renamed via the
set namecommand. The changes in this PR add a unique name check to resolve this problem.This was tested locally on a 1.18.2 spigot server.
closes #1706