Use pyproject.toml to specify build dependencies #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
pyproject.toml
file to list the build dependencies (see https://snarky.ca/what-the-heck-is-pyproject-toml/).Before, the build dependencies were listed in
setup.py
, but in order to read this file, you would need to have those dependencies installed (packaging, torch). By adding apyproject.toml
file, python knows which packages are needed to build flash-attention.