CYB-556 comments in tests; test for multisig #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianopol
commented
Jun 17, 2020
adrianopol
commented
- use boost-1.70 explicitly
- topology diagrams in simulator tests
- test multiple signature providers
|
The second commit is basically a tests reordering. All behavior changes are encapsulated in the first one. |
adrianopol
force-pushed
the
comments-and-tests-CYB-556
branch
from
4977361
to
d02e0f9
Compare
adrianopol
commented
Jun 18, 2020
| constexpr size_t sig_provs_per_node = 15; | ||
|
|
||
| // TODO: use this for testing set_signature_providers() | ||
| //~// generate arrays of signature providers & public keys (one array for each physical node) |
There was a problem hiding this comment.
I figured out some problems with set_signature_providers() function, it should be also tested. (Also it is currently not used anywhere, except simulator, so may be done later.)
| set(Boost_NO_BOOST_CMAKE ON CACHE STRING "ON or OFF") #TODO: Remove after Boost 1.70 CMake fixes are in place | ||
| find_package(Boost 1.67 REQUIRED COMPONENTS | ||
| set(Boost_NO_BOOST_CMAKE ON CACHE STRING "ON or OFF") | ||
| find_package(Boost 1.70 REQUIRED COMPONENTS |
There was a problem hiding this comment.
Boost-1.70 is used currently in all our images.
algys
approved these changes
Jun 22, 2020
adrianopol
force-pushed
the
comments-and-tests-CYB-556
branch
from
d02e0f9
to
96bf174
Compare
* use boost-1.70 explicitly * topology diagrams in simulator tests * test multiple signature providers
adrianopol
force-pushed
the
comments-and-tests-CYB-556
branch
from
96bf174
to
75e1e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.