Vault1 and Vault2 completed #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require(vaultBalances[msg.sender] >= _amount, "Insufficient balance in vault"); | ||
|
|
||
| vaultBalances[msg.sender] -= _amount; | ||
| token.transferFrom(address(this), msg.sender, _amount); |
There was a problem hiding this comment.
You can call the transfer function directly when transferring to user
|
|
||
| function deposit(uint _amount) external { | ||
| require(_amount > 0, "Invalid deposit amount"); | ||
| require(token.balanceOf(msg.sender) >= _amount, "Insufficient balance"); |
There was a problem hiding this comment.
This check is already taken care of in transferFrom function
| function mint(uint _amount) public payable { | ||
| require(_amount > 0, "Can't mint zero"); | ||
| require(msg.value == _amount*(1 ether), "Mint amount differs from sent amount"); | ||
| super._mint(msg.sender, msg.value); |
There was a problem hiding this comment.
You can directly call _mint without using the super keyword
|
|
||
| function mint(uint _amount) public payable { | ||
| require(_amount > 0, "Can't mint zero"); | ||
| require(msg.value == _amount*(1 ether), "Mint amount differs from sent amount"); |
There was a problem hiding this comment.
msg.value is in wei so better to consume _amount also in wei rather than ether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some rough edges, expecting feedback