Krishna s #25
Open
Krishna s #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function withdraw(uint _amount) external nonReentrant { | ||
| require(balances[msg.sender] >= _amount, "Insufficient balance"); | ||
| // first substract and then transfer to avoid reentry or other issues | ||
| balances[msg.sender] -= _amount; |
There was a problem hiding this comment.
Since you are subtracting the amount before calling transfer, this reentrancy check might not be required
There was a problem hiding this comment.
I know :-) but wanted to be careful anyways.
| function mint(uint _amount) payable external nonReentrant { | ||
| require(_amount == msg.value, "Amount of VAULT requested != Ether passed"); | ||
|
|
||
| // Question says "user" but not does not explicitly say if a contract |
There was a problem hiding this comment.
Both EOA and contracts should be able to call this function (they both can be users). Just calling _mint meets this purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homework submission