Charles naut #32
Open
Charles naut #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,39 @@ | |||
| //SPDX-License-Identifier: Unlicense | |||
| pragma solidity ^0.8.4; | |||
|
|
|||
| import "@openzeppelin/contracts/token/ERC20/ERC20.sol"; | |||
There was a problem hiding this comment.
Better to use ERC20 interface here than complete implementation
|
|
||
| function deposit(uint _amount) external { | ||
| require(_amount > 0, "Amount must be greater than 0"); | ||
| require(token.balanceOf(msg.sender) >= _amount, "Attemped to deposit amount greater than balance"); |
There was a problem hiding this comment.
This condition is checked in transferFrom function and is redundant here
|
|
||
| _mint(msg.sender, _amount); | ||
|
|
||
| emit Minted(_amount); |
There was a problem hiding this comment.
_mint already emits an event indicating a mint - https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol#L267
|
|
||
| transfer(msg.sender, _amount); | ||
|
|
||
| emit Burned(_amount); |
There was a problem hiding this comment.
_burn also emits an event indicating a burn - https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol#L295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.