Omard Vault Assignment #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event withdrawalEvent(uint256 _amount); | ||
|
|
||
| //Should take in deposit amount. Assume that the contract is pre-approved to transfer that amount | ||
| function deposit(uint256 _amount) public payable { |
There was a problem hiding this comment.
This can be an external function
| address public owner = msg.sender; | ||
| VaultToken vaultToken = VaultToken(owner); | ||
|
|
||
| mapping(address => mapping(ERC20 => uint256)) vaultBalance; |
There was a problem hiding this comment.
Since in this case vaultToken is fixed, why do we need this internal mapping from ERC20 to uint?
| payable | ||
| positiveAmounts(_amount) | ||
| { | ||
| transfer(_toAddress, _amount); |
There was a problem hiding this comment.
Why not call the _mint function here?
| positiveAmounts(_amount) | ||
| { | ||
| _burn(_toAddress, _amount); | ||
| emit tokensBurned(_toAddress, _amount); |
There was a problem hiding this comment.
_burn also emits an event indicating a burn - https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol#L295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12/12 tests passing