Fix and clarify OrWhere caveats in SqlBuilder docs #2149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
force-pushed
the
sqlbuilder-docfix
branch
from
ff2498a to
caf92e8
Compare
mgravell
approved these changes
Apr 8, 2025
|
thanks, appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into documentation of the
SqlBuilderabout combiningWhereandOrWhere, followed by reading up on it on #647, I noticed the behavior described in the readme differs from the behavior I'm currently observing (and which is also observed in #647).This PR updates the documentation example to match with current observed behavior and also adds some additional wording for better readability.