Skip to content

CI: use preinstalled sdk #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

CI: use preinstalled sdk #2160

merged 1 commit into from
Apr 27, 2025

Conversation

kbth
Copy link
Contributor

@kbth kbth commented Apr 27, 2025

Problem:

Packages requiring reboot:
 - vcredist140 (exit code 3010)
The recent package changes indicate a reboot is necessary.
 Please reboot at your earliest convenience.
Command exited with code 3010

Same as #2042.
Instead of explicitly installing the .NET SDK, this change uses the SDK preinstalled in the image.

The relevant line was originally added in the following PR to use .NET 9.0:
bd4f75b#diff-92ab9a36df5d8e9f7076f2fdec59492d1ac2d9cf27ea046767a7fc4d542ef3dc

On December 22, 2024, AppVeyor updated the Visual Studio 2022 image, and the included .NET SDK was upgraded to 9.0.101:
https://www.appveyor.com/updates/2024/12/22/

Therefore, these lines is no longer necessary.

@mgravell
Copy link
Member

mgravell commented Apr 27, 2025

Ah, thanks; that was vexing me but I hadn't had time to dig. It kinda irks me when the image keeps changing underneath us - kinda defeats the purpose of a target image! I've overridden the CI change block - let's see how it does!

@mgravell mgravell merged commit 5e6a6eb into DapperLib:main Apr 27, 2025
2 checks passed
@mgravell
Copy link
Member

merged with thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants