Fix GridReader wiring: use IParameterCallbacks instead of DynamicParameters in QueryMultiple (sync + async) #2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erCallbacks and add tests for QueryMultiple and QueryMultipleAsync to verify OnCompleted behavior.
…h was failing in AppVeyor.
|
I added another small commit to adjust the new tests, reason being that AppVeyor CI doesn’t have SQL Server available, so the first version of the tests failed there. With this update, the tests still run and pass locally when a database is present, but they no-op cleanly in CI without causing failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where
QueryMultipleandQueryMultipleAsynconly invoked OnCompleted when parameters were of type DynamicParameters.If a caller provided a custom parameter type that implemented
IParameterCallbacks, the callbacks were ignored.Changes Below:
Updated both sync and async code paths to cast command.bParameters to
IParameterCallbacksinstead ofDynamicParameters.Added unit tests to confirm that OnCompleted is now called for custom parameter objects in both sync and async scenarios.
What i found locally is :
Existing behavior with
DynamicParametersis unchanged.Custom implementations of
IParameterCallbacksnow work correctly.Fixes #2179.