-
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade eslint from 7.9.0 to 9.0.0 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
| Status | Scanner | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades eslint from v7 to v9 to resolve a security vulnerability. While the security fix is important, this is a major version upgrade that introduces significant breaking changes. The other ESLint-related dependencies in packages/browser-eslint-rules/package.json are incompatible with ESLint v9 and must also be upgraded. Merging this change without addressing these incompatibilities will break your linting setup. I have left a critical comment detailing the necessary actions. Please also ensure to update the yarn.lock file after resolving dependency conflicts.
| "@typescript-eslint/eslint-plugin": "^4.2.0", | ||
| "@typescript-eslint/parser": "^4.2.0", | ||
| "eslint": "^7.9.0", | ||
| "eslint": "^9.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading eslint to a new major version (^9.0.0) is a significant change that will likely break your current setup due to dependency incompatibilities. ESLint v9 introduced many breaking changes, including a new configuration system.
The other ESLint-related packages in this project are not compatible with ESLint v9 and must be upgraded simultaneously:
@typescript-eslint/parserand@typescript-eslint/eslint-plugin: Version^4.2.0is for older ESLint versions. You'll need to upgrade them to^7.0.0or newer for ESLint v9 compatibility.eslint-plugin-vue: Thenexttag is likely outdated. You will need a version of this plugin that supports ESLint v9 (likely v10.x or a pre-release).vue-eslint-parser: Version7.1.0is incompatible. This also needs to be upgraded to a version compatible with ESLint v9.
Before merging, please update these dependencies to compatible versions, test your linting process thoroughly, and regenerate the yarn.lock file.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/browser-eslint-rules/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-JSYAML-13961110
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution