Skip to content

Conversation

@Dargon789
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/browser-eslint-rules/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Prototype Pollution
SNYK-JS-JSYAML-13961110
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

@codesandbox
Copy link

codesandbox bot commented Nov 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by updating the eslint dependency. The primary goal is to remediate a known 'Prototype Pollution' vulnerability, ensuring the project benefits from the latest security patches and features provided by the newer eslint version.

Highlights

  • Security Upgrade: This pull request upgrades the eslint dependency from version 7.9.0 to 9.0.0 to address a 'Prototype Pollution' vulnerability (SNYK-JS-JSYAML-13961110) with a score of 631.
  • Yarn Zero-Installs Note: For users leveraging Yarn's zero-install feature, a manual yarn command will be necessary to update the .yarn/cache/ directory, as this PR does not automatically modify it.
  • Manual yarn.lock Update Required: The yarn.lock file failed to update automatically during the Snyk process and requires manual intervention to be updated before this pull request can be merged.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Nov 14, 2025

⚠️ Snyk checks are incomplete.

Status Scanner Critical High Medium Low Total (0)
⚠️ Open Source Security 0 0 0 0 See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades eslint from v7 to v9 to resolve a security vulnerability. While the security fix is important, this is a major version upgrade that introduces significant breaking changes. The other ESLint-related dependencies in packages/browser-eslint-rules/package.json are incompatible with ESLint v9 and must also be upgraded. Merging this change without addressing these incompatibilities will break your linting setup. I have left a critical comment detailing the necessary actions. Please also ensure to update the yarn.lock file after resolving dependency conflicts.

"@typescript-eslint/eslint-plugin": "^4.2.0",
"@typescript-eslint/parser": "^4.2.0",
"eslint": "^7.9.0",
"eslint": "^9.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading eslint to a new major version (^9.0.0) is a significant change that will likely break your current setup due to dependency incompatibilities. ESLint v9 introduced many breaking changes, including a new configuration system.

The other ESLint-related packages in this project are not compatible with ESLint v9 and must be upgraded simultaneously:

  • @typescript-eslint/parser and @typescript-eslint/eslint-plugin: Version ^4.2.0 is for older ESLint versions. You'll need to upgrade them to ^7.0.0 or newer for ESLint v9 compatibility.
  • eslint-plugin-vue: The next tag is likely outdated. You will need a version of this plugin that supports ESLint v9 (likely v10.x or a pre-release).
  • vue-eslint-parser: Version 7.1.0 is incompatible. This also needs to be upgraded to a version compatible with ESLint v9.

Before merging, please update these dependencies to compatible versions, test your linting process thoroughly, and regenerate the yarn.lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants