Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniRFRemix - Cleaned up error checking + Bug fix #124

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ESurge
Copy link
Contributor

@ESurge ESurge commented Oct 21, 2022

What's new

  • Cleaned up error checking in unirfremix_cfg_set_check function.
  • Fixed a bug where all options are disabled and set to N/A but it doesn't show Config is Invalid screen.
  • Added a Checking Config screen which is the default screen while the app checks the .sub files (useful for slower SD cards)

Description of Fixed Bug

  • Had a case where valid .sub files were being set as N/A
  • When all buttons were assigned to these files, all labels were N/A and buttons were disabled but Config is Invalid screen did not show.

Verification

  • Create a test file with errors and ensure checking is properly done
  • If at least one button is valid, app should proceed normally with errored buttons disabled and labels set to N/A
  • If all buttons have errors, app should show Config is Invalid screen

Notes

  • Did not check the tx_not_allowed screen as I did not change any code regarding this check

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Fixed a bug where all options are disabled and set to N/A but it doesn't show Config is invalid screen.
@ESurge ESurge requested a review from xMasterX as a code owner October 21, 2022 06:49
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xMasterX xMasterX merged commit 8fc3140 into DarkFlippers:dev Oct 21, 2022
@ESurge ESurge deleted the unleashed branch April 4, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants