Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate code in subghz FAAC scenes. #208

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

gid9798
Copy link
Collaborator

@gid9798 gid9798 commented Dec 15, 2022

What's new

Removing duplicate code in set FAAC scenes.
The required frequency is now determined on the basis of state of the SubGhzSceneSetType.

Verification

Try to create Faac SLH 868 MHz and Faac SLH 433MHz and check the frequency recorded in the file.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I verified, all works fine, now code is cleaner

@xMasterX xMasterX merged commit fbcb1f0 into DarkFlippers:dev Dec 15, 2022
@gid9798 gid9798 deleted the scene_set_faac branch December 16, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants