Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for solitaire card placement bug #253

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Fix for solitaire card placement bug #253

merged 1 commit into from
Dec 31, 2022

Conversation

doofy-dev
Copy link
Contributor

@doofy-dev doofy-dev commented Dec 31, 2022 •
edited by xMasterX
Loading

What's new

  • fixed card logic to not allow placing ♠3 on an empty place at the top.

Verification

  • Try to place ♠3 on one of the empty cells at the top. Originally the game allowed to place this card there.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@doofy-dev
solitaire:
27cc057 
fixed card placement to not allow placing ♠3 on top row when there was no card there.
xMasterX
xMasterX approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xMasterX xMasterX merged commit 8457da3 into DarkFlippers:dev Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doofy-dev @xMasterX