New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New battery display (Bar %) #278

Merged

xMasterX merged 3 commits into DarkFlippers:dev from Fasjeit:dev

Jan 18, 2023

Contributor

Fasjeit commented Jan 9, 2023 •

edited by xMasterX

Loading

What's new

New battery display (combining default bar with percent display)
Defining constants for Battery Display Types in desktop_settings.h

Verification

Select Bar % in Settings/Desktop/Battery View
Plug in charging cable

Checklist (For Reviewer)

PR has description of feature/bug
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix


          New battery display (Bar %)

4dc2a7f

Fasjeit requested a review from xMasterX as a code owner

January 9, 2023 14:55

Member

TQMatvey commented Jan 12, 2023

yeah seems cool, should get merged


          drawing own battery (Bar %) charging display

78139c5

Contributor Author

Fasjeit commented Jan 12, 2023

Now with its own charging level!

peterlewis commented Jan 12, 2023

Love this! Thank you so much for implementing it.

Contributor

RogueMaster commented Jan 15, 2023

Thank you! I have added this to RM too


          Merge branch 'dev' into batt-ui

959ea4d

xMasterX approved these changes

View reviewed changes

Member

xMasterX left a comment

Thanks!

xMasterX merged commit 24c12ab into DarkFlippers:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet