Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Hopefully) last filebrowser fixes #334

Merged
merged 2 commits into from
Feb 13, 2023
Merged

(Hopefully) last filebrowser fixes #334

merged 2 commits into from
Feb 13, 2023

Conversation

Willy-JL
Copy link
Contributor

@Willy-JL Willy-JL commented Feb 13, 2023 •
edited by xMasterX
Loading

What's new

  • Skip inputs while loading / sorting is in progress to prevent cursor / focus shift
  • Fix archive sorting, now respects chunked load threshold

Verification

  • Open a folder and go up / down before sorting is finished, no longer shifts cursor
  • Scroll a big folder in archive, no longer has sort bug

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Willy-JL Willy-JL requested a review from xMasterX as a code owner February 13, 2023 14:57
xMasterX
xMasterX approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xMasterX xMasterX merged commit 0abb888 into DarkFlippers:dev Feb 13, 2023
@Willy-JL Willy-JL deleted the last-filebrowser-fixes branch February 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Willy-JL @xMasterX