Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added external cc1101 module at cli #513

Merged
merged 3 commits into from
Jun 14, 2023
Merged

added external cc1101 module at cli #513

merged 3 commits into from
Jun 14, 2023

Conversation

Sil333033
Copy link
Contributor

@Sil333033 Sil333033 commented Jun 12, 2023 •
edited by xMasterX
Loading

What's new

  • When using the Subghz CLI, you can now use the external cc1101 module. First it was limited at the Internal module.

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Sil333033 Sil333033 requested a review from xMasterX as a code owner June 12, 2023 12:47
xMasterX
xMasterX approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I remade external module handling here just a bit and fixed issues with SPI handles, thanks for PR

@xMasterX xMasterX merged commit f078a48 into DarkFlippers:dev Jun 14, 2023
@Sil333033 Sil333033 deleted the subghz_cli_external branch June 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sil333033 @xMasterX