Manifest v3 #219
Merged
Manifest v3 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KillariDev
commented
Mar 3, 2023
•
KillariDev
commented
- Adds support for Manifest v3 while still maintaining support for V2
|
Ethers fix is required to get v3 working: ethers-io/ethers.js#3856 |
0xjimmy
approved these changes
Mar 9, 2023
| @@ -185,7 +185,7 @@ export function App() { | |||
|
|
|||
| function openAddressBook() { | |||
| sendPopupMessageToBackgroundPage( { method: 'popup_openAddressBook' } ) | |||
| return window.close() // close extension popup, chrome closes it by default, but firefox does not | |||
| return globalThis.close() // close extension popup, chrome closes it by default, but firefox does not | |||
There was a problem hiding this comment.
I don't think it's a bug. The browsers just work differently
| "web_accessible_resources": [ | ||
| { | ||
| "resources": ["vendor/*", "js/*", "inpage/*"], | ||
| "matches": ["<all_urls>"] // not sure if this is right? |
There was a problem hiding this comment.
Would be much better if we did activeTab instead, but that requires users to click the extension icon to activate it. This permission requires that we get "read and write access to all websites you visit".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.