Improve error handling #210
Conversation
✅ Deploy Preview for thunderous-smakager-9b6002 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jubalm
force-pushed
the
feature/improved-error-handling
branch
2 times, most recently
from
3bd4f59 to
5b9960a
Compare
jubalm
force-pushed
the
feature/improved-error-handling
branch
from
5b9960a to
f2407ad
Compare
jubalm
force-pushed
the
feature/improved-error-handling
branch
from
72ed394 to
345a3b0
Compare
jubalm
force-pushed
the
feature/improved-error-handling
branch
from
345a3b0 to
88831ca
Compare
| // TODO: implement amount query | ||
| console.log('token amount', receipt, addFavoriteStore) | ||
| return <></> |
There was a problem hiding this comment.
I feel this should be done before this is merged?
There was a problem hiding this comment.
updated the current PR to include the changes
| waitFor(async () => { | ||
| const signer = await browserProvider.getSigner() | ||
| if (!browserProvider.value) { | ||
| throw makeError('No compatible web3 wallet detected.', 'UNKNOWN_ERROR', { error: { code: 4900 } }) |
There was a problem hiding this comment.
this error message and code repeats, we could make it a constant or a function
There was a problem hiding this comment.
True, created an issue for this #212
| /** | ||
| * Match string equality | ||
| */ | ||
| export function areEqualStrings(a: string, b: string, caseSensitive?: true) { |
There was a problem hiding this comment.
do you need non-case sensitive check? if so, you could just not call this function and use "a === b". And when you do, you could rename this function to "areEqualStringsCaseInsentive" or similar
There was a problem hiding this comment.
Tracking this suggestion to #213 to push needed functionality to main
Co-authored-by: KillariDev <13102010+KillariDev@users.noreply.github.com>
Co-authored-by: KillariDev <13102010+KillariDev@users.noreply.github.com>
Co-authored-by: KillariDev <13102010+KillariDev@users.noreply.github.com>
jubalm
force-pushed
the
feature/improved-error-handling
branch
from
ca80987 to
a2f8e77
Compare
Improve error handling, adding proper notices and error messages on transfer:
EthereumcontextWalletcontextNotable UI update:
Resolves #138