Skip to content

Conversation

@lgeiger
Copy link

@lgeiger lgeiger commented Aug 26, 2025

Adds a test for vllm-project#23672

@lgeiger lgeiger requested a review from DarkLight1337 as a code owner August 26, 2025 16:23
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

Copy link
Owner

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@DarkLight1337 DarkLight1337 merged commit 229d02e into DarkLight1337:fix-hash-shape Aug 26, 2025
2 checks passed
@lgeiger
Copy link
Author

lgeiger commented Aug 26, 2025

Arg sorry, forgot to signoff the commit

@DarkLight1337
Copy link
Owner

No worries, I can skip the check in the main CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants