Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DbDataSource implementation #553

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

smbecker
Copy link
Contributor

@smbecker smbecker commented Dec 2, 2024

This PR adds a DbDataSource implementation, which makes integration into DI containers much simpler.

@smbecker
Copy link
Contributor Author

smbecker commented Dec 3, 2024

@DarkWanderer, any advice on why the "compare coverage" workflow is failing?

@DarkWanderer
Copy link
Owner

Greetings. This run unfortunately doesn't work between fork and main repo due to GitHub behavior quirk I haven't nailed down. I have disabled it in 'main' for now - checks should pass now if you rebase

P.S. I think it would be beneficial to add some tests here, even if trivial "create and call 1-2 methods"

@smbecker
Copy link
Contributor Author

Greetings. This run unfortunately doesn't work between fork and main repo due to GitHub behavior quirk I haven't nailed down. I have disabled it in 'main' for now - checks should pass now if you rebase

Rebased

P.S. I think it would be beneficial to add some tests here, even if trivial "create and call 1-2 methods"

Added a test

@DarkWanderer DarkWanderer merged commit 9a60f48 into DarkWanderer:main Dec 10, 2024
20 checks passed
@DarkWanderer
Copy link
Owner

LGTM - thanks for your contribution!

It would also be beneficial to add it to ClickHouseConnectionFactory, so it's helpful for even more users

@smbecker
Copy link
Contributor Author

It would also be beneficial to add it to ClickHouseConnectionFactory, so it's helpful for even more users

I guess I didn't even realize that DbProviderFactory had an overload for CreateDataSource. Implemented in #557.

@smbecker smbecker deleted the sb-datasource branch December 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants