Add PKCE config parameter #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkaOnLine
reviewed
Aug 4, 2022
resources/views/index.blade.php
Outdated
Comment on lines
70
to
72
| ui.initOAuth({ | ||
| usePkceWithAuthorizationCodeGrant: "{!! (bool)config('l5-swagger.defaults.ui.authorization.use_pkce_with_authorization_code_grant') !!}" | ||
| }) |
There was a problem hiding this comment.
Should we wrap this with if:
Suggested change
| ui.initOAuth({ | |
| usePkceWithAuthorizationCodeGrant: "{!! (bool)config('l5-swagger.defaults.ui.authorization.use_pkce_with_authorization_code_grant') !!}" | |
| }) | |
| @if((bool)config('l5-swagger.defaults.ui.authorization.use_pkce_with_authorization_code_grant')) | |
| ui.initOAuth({ | |
| usePkceWithAuthorizationCodeGrant: "{!! (bool)config('l5-swagger.defaults.ui.authorization.use_pkce_with_authorization_code_grant') !!}" | |
| }) | |
| @endif |
Or this call ui.initOAuth will not change default behaviour if we are not using oAuth?
There was a problem hiding this comment.
Good idea, I suggest checking that at least one of the security schemes type is oauth2. Only with this condition we add ui.initOauth. Besides that, I moved option use_pkce_with_authorization_code_grant to new oauth2 array element, I think in such way it is more readable.
Please, see details in my latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new config option
use_pkce_with_authorization_code_grantwith default value set to false.This new parameter allows to authorize through Authorization Code Grant with PKCE, because if set to true, it enables swagger-ui option
usePkceWithAuthorizationCodeGrant. #485