Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tooltip options #191

Open
wants to merge 8 commits into
base: 1.19.4
Choose a base branch
from

Conversation

RobertHoueland
Copy link

A couple small changes, feel free to change anything. Main goal was to add a bit more information to the tooltips, optional of course.

  • Enchantment tooltips show the maximum level of the enchantment
  • When shift is held down, enchantment tooltips show every vanilla item that the enchantment can be applied to
  • Both of these changes can be disable in the config file

example image: https://i.imgur.com/Sg6gVye.png

Notes:

  • Item categories are hard coded for every vanilla item that has applicable enchantments, so if a mod adds a new item that can be enchanted, it won't be supported
  • Weapons/tools/armor show up as "Diamond Sword" rather than just "Sword"
  • Holding shift over an item with many enchantments has a very long tooltip which sometimes goes off screen
  • The translations are from google translate so they definitely could be incorrect

@Darkhax
Copy link
Member

Darkhax commented May 2, 2023

Thanks for the PR. I've done a quick skim through the changes and they seem fine however there are a few things I would like to change. I've got a lot going on right now so a proper review will have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants