Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openrgb device updated implementation #338

Open
wants to merge 6 commits into
base: Development
Choose a base branch
from

Conversation

Aytackydln
Copy link
Contributor

@Aytackydln Aytackydln commented Jun 18, 2023

This PR adds DevicesChanged implementation for OpenRgb library.

Breaking Changes

  • Device names

Previously device names were created different each time, adding number in a paranthesis in their names. This caused problems when devices were reconnected or while checking if the device is new or not.

My proposal is adding a hash to the Device Names based on serial or device location (for internal devices). For zones and segments, their zone or segment name is also appended and not using incremental numbers in Device Names

@Aytackydln Aytackydln marked this pull request as ready for review June 20, 2023 21:36
@Aytackydln
Copy link
Contributor Author

I added naming changes when DeviceId doesn't exist, for example with fans. Same change with common commit is also in OpenRGB PR

…to openrgb-device-updated

# Conflicts:
#	RGB.NET.Devices.OpenRGB/OpenRGBDeviceProvider.cs
…to openrgb-device-updated

# Conflicts:
#	RGB.NET.Core/Ids/IdGenerator.cs
#	RGB.NET.Devices.OpenRGB/OpenRGBDeviceProvider.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant