Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use http instead of https for public ip api #2

Merged
merged 8 commits into from
Feb 11, 2023

Conversation

DaruZero
Copy link
Owner

Description

This PR solves the certificate issue when calling the public ip API

Related issues

Fixes #1

Type of change

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run the container

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

@DaruZero DaruZero added flag: high priority This issue or pull request needs to be resolved ASAP lang: go This issue or pull request is related to Go status: needs testing This issue or pull request needs testing labels Feb 10, 2023
@DaruZero DaruZero linked an issue Feb 10, 2023 that may be closed by this pull request
@welcome
Copy link

welcome bot commented Feb 10, 2023

Thanks for opening this pull request! Please check out our contributing guidelines.

cmd/dns.go Fixed Show fixed Hide fixed
@DaruZero DaruZero marked this pull request as ready for review February 11, 2023 17:41
@DaruZero DaruZero merged commit 19306be into main Feb 11, 2023
@DaruZero DaruZero deleted the fix/1/bug-failed-tls-check-for-public-ip-api branch February 11, 2023 17:42
@welcome
Copy link

welcome bot commented Feb 11, 2023

Congrats on merging your first pull request! Welcome to the community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: high priority This issue or pull request needs to be resolved ASAP lang: go This issue or pull request is related to Go status: needs testing This issue or pull request needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: failed tls check for public IP API
1 participant