Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment validation tests not enabled when building the Docker image #603

Closed
nicholas-fr opened this issue Nov 2, 2022 · 5 comments
Closed

Comments

@nicholas-fr
Copy link

It appears the segment validation tests are not enabled when building the Docker image:
docker build -t dash-if-conformance:latest -t dash-if-conformance:30d98fd .

php Process_cli.php --help only shows:

Usage: Process_cli.php [options] URL
  -h, --help            Print this help text
  -c, --cmaf            Enable CMAF checking
  -w, --ctawave         Enable CTAWAVE checking
  -H, --hbbtv           Enable HBBTV checking
  -D, --dvb             Enable DVB checking
  -l, --lowlatency              Enable DASH-IF IOP Low Latency checking
  -i, --iop             Enable DASH-IF interoperability checking

Is segment validation not enabled or not working in the latest build, or is there something I'm missing?

For example, using:
https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2022-10-17/stream.mpd

With additional tests:
Segment Validation
CMAF
CTA WAVE

php Process_cli.php --cmaf --ctawave --segments https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2022-10-17/stream.mpd

There is no segment validation feedback in the output:

{
"enabled_modules":
    [
        {
        "name": "MPEG-DASH Common"
        },
        {
        "name": "CMAF"
        },
        {
        "name": "CTA-WAVE"
        }
    ],
"entries":
    {
    "MPEG-DASH Common":
        {
        "MPD":
            {
            "info":
                [
                "Schematron output: 0XLink resolving successful\n\n\nMPD validation successful - DASH is valid!\n\n\nSchematron validation successful - DASH is valid!\n\n\n"
                ],
            "test":
                [
                    {
                    "messages":
                        [
                        "XLink resolving succesful",
                        "MPD validation succesful",
                        "Schematron validation succesful"
                        ],
                    "section": "Commmon",
                    "spec": "MPEG-DASH",
                    "state": "PASS",
                    "test": "Schematron Validation"
                    }
                ],
            "verdict": "PASS"
            },
        "verdict": "PASS"
        },
    "Stats":
        {
        "LastWritten": "2022-11-02 02:02:58"
        }
    },
"source": "https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2022-10-17/stream.mpd",
"verdict": "PASS"
}
@dsilhavy
Copy link
Contributor

dsilhavy commented Nov 2, 2022

@nicholas-fr We will release a new version latest mid next week that will include segment validation via CLI. This will then automatically be available at https://beta.conformance.dashif.org/. In the meantime you can already try this branch: https://github.com/Dash-Industry-Forum/DASH-IF-Conformance/tree/features/refactorPhase1

@nicholas-fr
Copy link
Author

nicholas-fr commented Nov 2, 2022

Thanks @dsilhavy, I look forward to testing the new version.

I built a Docker image using the features/refactorPhase1 branch.
Unfortunately, I get the following error with the latest WAVE test content when segment validation is enabled:

php Process_cli.php --cmaf --ctawave --segments https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2022-10-17/stream.mpd
Going to run segment validator with config file /var/www/html/Utils/sessions/1667406068/Period0/Adaptation0/Representation0/segmentValidatorConfig.txt

Fatal error: Uncaught Error: Call to a member function getAttribute() on null in /var/www/html/CMAF/impl/checkCMAFTracks.php on line 39

Error: Call to a member function getAttribute() on null in /var/www/html/CMAF/impl/checkCMAFTracks.php on line 39

Call Stack:
    0.0011     397504   1. {main}() /var/www/html/Utils/Process_cli.php:0
    0.0088    1393728   2. process_MPD() /var/www/html/Utils/Process_cli.php:98
    2.7287    1417888   3. processAdaptationSetOfCurrentPeriod() /var/www/html/DASH/processMPD.php:85
   21.3593    1420080   4. DASHIF\ModuleCMAF->hookRepresentation() /var/www/html/DASH/processMPD.php:138
   21.3593    1420080   5. DASHIF\ModuleCMAF->checkCMAFTracks() /var/www/html/CMAF/module.php:121
   21.3597    1579104   6. include('/var/www/html/CMAF/impl/checkCMAFTracks.php') /var/www/html/CMAF/module.php:126

Is this a known issue?

@dsilhavy
Copy link
Contributor

dsilhavy commented Nov 2, 2022

Thanks @nicholas-fr we will check this. I did see a similar error before in a different file though.

Phencys added a commit that referenced this issue Nov 4, 2022
@dsilhavy
Copy link
Contributor

dsilhavy commented Nov 4, 2022

@nicholas-fr Erik addressed this issue with the latest commit (see above). Can you confirm that this is fixed for you?

@nicholas-fr
Copy link
Author

Thanks @dsilhavy the segment validation now runs.

There are a couple of new issues to mention (issues #604 and #605).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants