Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string used for DVB DASH 2017 profile tests in MPD validator #589

Merged

Conversation

wschidol
Copy link
Contributor

The codebase for the MPD validator contains tests against the DVB DASH 2017 profile. The tests however were never executed because the profile identifier string was erroneous. Fix this by using the correct identifier urn:dvb:dash:profile:dvb-dash:2017.

  this enables the DVB DASH 2017 profile
@dsilhavy dsilhavy self-requested a review June 24, 2022 10:22
@wschidol
Copy link
Contributor Author

The DASH/mpdvalidator/schematron directory contains the scripts create_val_schema.* which compile the schematron files into xslt (stored as output/val_schema.xsl). Should contributors to the schematron part of the codebase also, as part of the contribution, create and commit the output/val_schema.xsl file?
Also, run_samples.* validate all of the example files and output the results into output/result_ex*.xml. I assume that this affords some sort of regression testing by making sure that changes to the schematron source don't create regressions though I am not entirely sure how that testing is actually done. How should these regression tests be handled?

@dsilhavy dsilhavy added this to the JCCP - Beta Release milestone Jun 29, 2022
@dsilhavy
Copy link
Contributor

@wschidol Thank you for the PR and your questions. We will discuss this internally and get back to you

@wschidol
Copy link
Contributor Author

@wschidol Thank you for the PR and your questions. We will discuss this internally and get back to you

I am using a workflow now where I run all the samples before and after the change, and with a small in-house script create "digests" of the outputs. I then review any difference in the digests whether they are intentional or an unintended side effect.

@wschidol
Copy link
Contributor Author

wschidol commented Jul 8, 2022

Any progress on this? Many other fixes are depending on this one, so I'd like to get it "out the door" so to speak.

@dsilhavy
Copy link
Contributor

dsilhavy commented Jul 8, 2022

@wschidol Sorry for the delay, looks good to me, gonna merge this

@dsilhavy dsilhavy merged commit a6bcbf7 into Dash-Industry-Forum:development Jul 8, 2022
@wschidol wschidol deleted the bugfix/test-dvb-dash-2017 branch July 8, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants