-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC3_v2.0.0 with BufferOccupancyABR: media decode errors, does not play until end #1152
Comments
@blacktrash Thanks for the feedback. We are in the experimental alpha phase with BOLA and we know about some issues but not this one. We have started a Wiki to track progress and issues during the 2.1 release https://github.com/Dash-Industry-Forum/dash.js/wiki/BOLA-status/ |
This sample |
I reproduced this issue in a throttled Chrome connection, and traced it to an issue when the ScheduleController delays loading a fragment - BOLA sometimes asks for a fragment to be delayed but the old ABR logic does not. Moving the delay from the FragmentModel to the FragmentLoader fixed the issue in my test. It works by allowing the xhr request to be generated right away, otherwise the stream might end and the request can no longer be generated. The delay is then inserted just before sending the xhr request. I still need to check that the fix really solves the issue and that it doesn't break anything else. |
@spiterikevin - I can confirm that this fixes the issue with end of video detection in Chrome. |
@blacktrash - thank you for the quick feedback. I'll keep looking into the muxing problem. |
@spiterikevin - FYI, I've managed to get the encoding error and color 'effect' in Firefox too. |
Update of test stream URLs: |
Both test stream urls are not available anymore. If you still encounter an issue with your streams please file a new ticket. |
With buffer occupancy enabled:
Works with old ABR logic.
The text was updated successfully, but these errors were encountered: