Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC3_v2.0.0 with BufferOccupancyABR: media decode errors, does not play until end #1152

Closed
phloxic opened this issue Feb 9, 2016 · 9 comments

Comments

@phloxic
Copy link

phloxic commented Feb 9, 2016

With buffer occupancy enabled:

  • Safari (and very rarely in Firefox and Chrome): now and then media decode error
  • Chrome: with throttled connection (e.g. good 2G in network console) videos often do not play through

Works with old ABR logic.

@dsparacio
Copy link
Contributor

@blacktrash Thanks for the feedback. We are in the experimental alpha phase with BOLA and we know about some issues but not this one. We have started a Wiki to track progress and issues during the 2.1 release

https://github.com/Dash-Industry-Forum/dash.js/wiki/BOLA-status/

@dsparacio dsparacio added the BOLA label Feb 10, 2016
@phloxic
Copy link
Author

phloxic commented Feb 13, 2016

@spiterikevin
Copy link
Contributor

I reproduced this issue in a throttled Chrome connection, and traced it to an issue when the ScheduleController delays loading a fragment - BOLA sometimes asks for a fragment to be delayed but the old ABR logic does not.

Moving the delay from the FragmentModel to the FragmentLoader fixed the issue in my test. It works by allowing the xhr request to be generated right away, otherwise the stream might end and the request can no longer be generated. The delay is then inserted just before sending the xhr request. I still need to check that the fix really solves the issue and that it doesn't break anything else.

spiterikevin@3768a7a

@phloxic
Copy link
Author

phloxic commented Feb 21, 2016

@spiterikevin - I can confirm that this fixes the issue with end of video detection in Chrome.

@phloxic
Copy link
Author

phloxic commented Feb 21, 2016

Regarding encoding errors in Safari: This seems to have improved in 2.0.0 proper.

However, testing with throttled connection in Safari still reveals muxing problems with (emergency?) down switches which do not happen with BOLA turned off:

screen shot 2016-02-21 at 10 39 22 am

vs 'original' colors:

screen shot 2016-02-21 at 10 46 21 am

@spiterikevin
Copy link
Contributor

@blacktrash - thank you for the quick feedback. I'll keep looking into the muxing problem.

@phloxic
Copy link
Author

phloxic commented Feb 22, 2016

@spiterikevin - FYI, I've managed to get the encoding error and color 'effect' in Firefox too.

@phloxic
Copy link
Author

phloxic commented Jun 17, 2016

Update of test stream URLs:
http://stream.flowplayer.org/night1-heaac.mpd (with HE-AAC) and http://stream.flowplayer.org/night1.mpd (with LC-AAC)
I actually have to re-check with 2.1.1.

@dsparacio dsparacio removed the BOLA label Jul 18, 2017
@dsilhavy
Copy link
Collaborator

dsilhavy commented Jan 8, 2020

Both test stream urls are not available anymore. If you still encounter an issue with your streams please file a new ticket.

@dsilhavy dsilhavy closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants