forked from Dash-Industry-Forum/dash.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
postpone fragment delaying until just before sending xhr request
- Loading branch information
1 parent
d01daa9
commit 3768a7a
Showing
2 changed files
with
9 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3768a7a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a stream ends during a delay for loading a fragment, the fragment might then not be loaded correctly. This can be resolved by moving the delay from the FragmentModel to the FragmentLoader. It works by allowing the xhr request to be generated right away, because if the stream ends then there might be a problem generating the request. The delay is then inserted just before sending the xhr request.
After this change, there will no longer be a need for hooking the PLAYBACK_SEEKING event in the FragmentModel.