Added subtitle event handling for manual rendering the subtitles #4360
Conversation
This adds two new media player events: `CUE_ENTER` and `CUE_EXIT`. With these events you can render the subtitles without relying on the browser. This makes it possible to fully customize the UI for the subtitles. To enable the events, set the `fireCueEvents` setting to true. For details check out the example in `samples/captioning/events.html`.
|
@bitboxer Thank you for the PR. Following our contribution guidelines, and since this seems to be your first PR have you signed the feedback agreement yet? If not can you please send me a signed copy of the dash.js feedback agreement? |
|
@dsilhavy I just send you an email with the signed agreement. |
|
@dsilhavy I updated the PR with your suggestions. I opted for the |
|
@dsilhavy did you have time to have a look into the latest changes? Is there anything left that I should/can do? |
|
@bitboxer Thank you for the changes, I only had some "minor" code style comments. If you can address them it would be great. Otherwise let me know and I add them after your PR is merged |
|
@dsilhavy I now added a commit that should fix all the things you mentioned. Let me know if there is anything else todo. Happy to help. |
|
❤️ Thanks for merging this. |
Thank you for your work on this :) |
…h-Industry-Forum#4360) * Added subtitle event handling for manual rendering the subtitles This adds two new media player events: `CUE_ENTER` and `CUE_EXIT`. With these events you can render the subtitles without relying on the browser. This makes it possible to fully customize the UI for the subtitles. To enable the events, set the `fireCueEvents` setting to true. For details check out the example in `samples/captioning/events.html`.
This adds two new media player events:
CUE_ENTERandCUE_EXIT. With these events you can render the subtitles without relying on the browser. This makes it possible to fully customize the UI for the subtitles. To enable the events, set thefireCueEventssetting to true.For details check out the example in
samples/captioning/events.html.I am a bit unclear about the testing strategy of dash.js at the moment, because of that those are currently missing. Would love to add them after you explained where I should put them.
Closes #4317