Switch away from FIT payload #106

SergiiDmytruk · 2022-02-23T16:10:10Z

This makes skiboot an ELF payload.

Two DTB files are prepared for two configurations and included into CBFS during build. In sources 2-CPU version incudes 1-CPU file, so it should be easy to maintain. Can switch to DT overlays for greater flexibility and saving some space, code supports them and dtc probably does too.

krystian-hebel

Rebase please
Memory range containing CBMEM is not reserved, probably applies to all ranges normally reserved by coreboot
No /firmware/coreboot node in device tree (required by cbmem util)

Build it as ELF instead. Change-Id: I2d2e98fdd2f5be38438a2992c1f7d145384e2e12 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk · 2022-04-07T17:09:13Z

@krystian-hebel Copied two functions from src/lib/fit.c. Is it worth moving them to a separate conditionally-compiled source file and enable it for SUPPORT_FIT_PAYLOAD and POWER9? Or maybe there is another way of doing this.

krystian-hebel

This confirms what I wrote on the mailing list about choosing FIT 🙂

I added some comments about stripping unnecessary parts from that code. Memory ranges walk will have to be significantly changed, but "coreboot" node is mostly the same as for FIT. Doesn't make sense to create a separate file just for that, though. Moving it to device_tree.c could help, but I don't know if upstream would be OK with it.

src/soc/ibm/power9/chip.c

krystian-hebel

Additionally, ARCH_PPC64 can be now removed from config FIT_PAYLOAD in payloads/Kconfig

EDIT: and PAYLOAD_FIT_SUPPORT, and probably PAYLOAD_SKIBOOT in that file can be removed from list of non-compressable payloads.

src/soc/ibm/power9/chip.c

src/mainboard/raptor-cs/talos-2/Makefile.inc

Change-Id: I447ad54cfabf1753c679e4645b4f8694db1a9dd7 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

Change-Id: Id1d1bf193c507d11cefbd05461a5fbef958276bd Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk · 2022-04-07T20:27:09Z

Also removed 6 sensors from 2-cpus.dts which were previously removed in 487d707, forgot to return to this after a rebase.

krystian-hebel · 2022-04-08T12:33:33Z

src/mainboard/raptor-cs/talos-2/1-cpu.dts

-				compatible = "ibm,opal-i2c\0ibm,power8-i2c-port\0ibm,power9-i2c-port";
-				reg = <0x00>;
-
-				eeprom@50 {


@SergiiDmytruk I removed those SPD nodes for CPU0 when I thought that only installed DIMMs have them, but apparently they are always present. Can you add them back, please? You can read them from https://github.com/3mdeb/openpower-coreboot-docs/blob/main/logs/fdt.bin to skip flashing Hostboot and dumping FDT from it.

Added them back.

src/soc/ibm/power9/chip.c

Load and set up FDT ourselves. Change-Id: Id3380fb706d427ec8bb8083515e11ce93600c6f9 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

They were removed based on an assumption that only installed DIMMs have them which turned out to be false. Change-Id: Ib971e4b40957f2b99fa9c65501082bc7da3cd6e1 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

* Start with PCI initialization Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Phase 1 of initialization Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Reorganize code a bit Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Enable RI/DI for PCIe Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * First half of Phase2 (PEC init) Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Second half of Phase2 (PHB init) Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Reorganize code into isteps in romstage Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Remove bad check for dying Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Small code improvements Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Fixes for istep 10.10 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Non-functional code improvements Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Use udelay() where appropriate Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Fixes for istep 14.3 * Small changes for consistency. * Access some registers through a nest chiplet ID. * Fix a bug in PEC initialization (ATTR_PROC_PCIE_CACHE_INJ_MODE). Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Fix value of MBOX_SCRATCH_REG6_GROUP_PUMP_MODE Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Remove non-breaking spaces in istep_14_3.c Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> * Invoke istep_10_* earlier in romstage Change-Id: I229f3b40d1f8b115eaa1d9d9b9e813a43ee807ae Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk requested a review from krystian-hebel February 23, 2022 16:10

SergiiDmytruk added the raptor-cs_talos-2 label Feb 23, 2022

SergiiDmytruk force-pushed the raptor-cs_talos-2/elf_payload branch from a2a0faf to 64c091f Compare March 3, 2022 16:29

SergiiDmytruk force-pushed the raptor-cs_talos-2/dt_with_2nd_cpu branch 2 times, most recently from 6cab1de to d6010ce Compare March 21, 2022 21:58

krystian-hebel changed the base branch from raptor-cs_talos-2/dt_with_2nd_cpu to raptor-cs_talos-2/develop April 7, 2022 12:59

krystian-hebel requested changes Apr 7, 2022

View reviewed changes

payloads/external/skiboot/: stop using FIT

a3d1b28

Build it as ELF instead. Change-Id: I2d2e98fdd2f5be38438a2992c1f7d145384e2e12 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk force-pushed the raptor-cs_talos-2/elf_payload branch from 64c091f to cc475c9 Compare April 7, 2022 14:53

SergiiDmytruk requested a review from krystian-hebel April 7, 2022 17:06

krystian-hebel requested changes Apr 7, 2022

View reviewed changes

src/soc/ibm/power9/chip.c Outdated Show resolved Hide resolved

src/soc/ibm/power9/chip.c Outdated Show resolved Hide resolved

SergiiDmytruk force-pushed the raptor-cs_talos-2/elf_payload branch from bc0880b to 418b993 Compare April 7, 2022 18:25

SergiiDmytruk requested a review from krystian-hebel April 7, 2022 18:26

krystian-hebel requested changes Apr 7, 2022

View reviewed changes

src/soc/ibm/power9/chip.c Outdated Show resolved Hide resolved

src/mainboard/raptor-cs/talos-2/Makefile.inc Outdated Show resolved Hide resolved

SergiiDmytruk added 2 commits April 7, 2022 23:14

payloads/Kconfig: undo changes made for FIT skiboot

5ea3d49

Change-Id: I447ad54cfabf1753c679e4645b4f8694db1a9dd7 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

mb/raptor-cs/talos-2/: embed CPU-count-dependent DTBs into CBFS

55050c2

Change-Id: Id1d1bf193c507d11cefbd05461a5fbef958276bd Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk force-pushed the raptor-cs_talos-2/elf_payload branch from 418b993 to 8800f36 Compare April 7, 2022 20:26

SergiiDmytruk requested a review from krystian-hebel April 7, 2022 20:27

krystian-hebel reviewed Apr 8, 2022

View reviewed changes

SergiiDmytruk added 2 commits April 8, 2022 16:51

soc/power9/: switch away from FIT payload

c63d251

Load and set up FDT ourselves. Change-Id: Id3380fb706d427ec8bb8083515e11ce93600c6f9 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

mb/raptor-cs/talos-2/1-cpu.dts: add missing eeprom nodes

236fe66

They were removed based on an assumption that only installed DIMMs have them which turned out to be false. Change-Id: Ib971e4b40957f2b99fa9c65501082bc7da3cd6e1 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>

SergiiDmytruk force-pushed the raptor-cs_talos-2/elf_payload branch from 8800f36 to 236fe66 Compare April 8, 2022 14:00

SergiiDmytruk requested a review from krystian-hebel April 8, 2022 14:01

krystian-hebel approved these changes Apr 8, 2022

View reviewed changes

krystian-hebel merged commit 236fe66 into raptor-cs_talos-2/develop Apr 8, 2022

krystian-hebel deleted the raptor-cs_talos-2/elf_payload branch April 8, 2022 19:28

tlaurion mentioned this pull request Jul 22, 2024

Nlnet past funded work placeholder for Accessible Security project (2019) linuxboot/heads#1729

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch away from FIT payload #106

Switch away from FIT payload #106

SergiiDmytruk commented Feb 23, 2022

krystian-hebel left a comment

SergiiDmytruk commented Apr 7, 2022

krystian-hebel left a comment

krystian-hebel left a comment •

edited

Loading

SergiiDmytruk commented Apr 7, 2022

krystian-hebel Apr 8, 2022

SergiiDmytruk Apr 8, 2022

Switch away from FIT payload #106

Switch away from FIT payload #106

Conversation

SergiiDmytruk commented Feb 23, 2022

krystian-hebel left a comment

Choose a reason for hiding this comment

SergiiDmytruk commented Apr 7, 2022

krystian-hebel left a comment

Choose a reason for hiding this comment

krystian-hebel left a comment • edited Loading

Choose a reason for hiding this comment

SergiiDmytruk commented Apr 7, 2022

krystian-hebel Apr 8, 2022

Choose a reason for hiding this comment

SergiiDmytruk Apr 8, 2022

Choose a reason for hiding this comment

krystian-hebel left a comment •

edited

Loading