Make trusted boot work in skiboot #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystian-hebel
requested changes
Jun 13, 2022
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/trusted_boot
branch
2 times, most recently
from
03638b5 to
6fa614b
Compare
That is the format expected by skiboot and Linux. Change-Id: Ic2e8b83316938ca8385afae621b7b1599c74e752 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I26bfd2ef07a71c2f02394fccd90a45f73ad07e2c Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: I576b7066d682057ef58e2c8bbbd61dd69e45ec20 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/trusted_boot
branch
from
6fa614b to
265a977
Compare
krystian-hebel
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to change TCPA log format (from coreboot-specific to TPM2 format) and updates device tree to enable trusted boot in skiboot.
Initially used log format from TPM1.2, but skiboot parsed only first entry, so changed it. Linux can handle both formats, not sure how it picks the one to use though. In case of issues with Linux, might modify skiboot to use the other format.
With this PR and corresponding changes in skiboot (Dasharo/skiboot#1), it imports log, appends to it and updates PCRs.