Make cbmem work and print TCPA log #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way this memory will be available for mapping via /dev/mem even when kernel is configured with CONFIG_[IO_]STRICT_DEVMEM. This makes CBMEM available in host via cbmem tool. Change-Id: I968067ebb8dfcf816fe72ea9c00985d0d10f5fbb Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
The range needs to be filled in log-tpm.c, so it's available in write_tables(). CBMEM_ID_TCPA_LOG_REF was added to avoid the necessity of code outside of log-tpm.c to know about the layout. Change-Id: I1deae6ce00d1d7a96c02358b387592c41a8ac5f8 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Aligning use of the log for skiboot, cbmem and Linux drivers is pain in the ass not just in terms of access to reserved memory but even in terms of endianness. Just pass log to skiboot, which is enough for printing it via `cbmem` because Linux doesn't change it and `/sys/kernel/security/tpm0/binary_bios_measurements` is not needed. Change-Id: I4014d4944e876d34e6a392b9ce7104d0ad57b6f9 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: I1cd89d720ba79e44b033fe5b1ee6a21bfa3584b3 Signed-off-by: Igor Bagnucki <igor.bagnucki@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Detected via header_bytes field of table header. Change-Id: I6c5c15c4590a45cbcbf4c6fd11fac936a5412430 Signed-off-by: Igor Bagnucki <igor.bagnucki@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: I113e1b4fd5932c28075930d318b8938ab10d75c4 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
raptor-cs_talos-2/cbmem
branch
from
f71d239
to
c8f357f
Compare
krystian-hebel
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
@SergiiDmytruk approved, but please also change Skiboot revision in this PR.
Change-Id: I77df37c63b250d153f4297135bbff4333aa36696 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
|
@krystian-hebel Added repository option and updated revision. |
macpijan
changed the base branch from
raptor-cs_talos-2/develop
to
raptor-cs_talos-2/tpm-poc-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes cleaned up changes from #62, because they were necessary.
If Dasharo/skiboot#2 is merged first, this PR can be changed to update skiboot payload to use that fork.