Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FSI for Power9 #56

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

SergiiDmytruk
Copy link
Member

Not much tested, but this works and prints zeros:

printk(BIOS_EMERG, "read_fsi(0, 0x3418) = 0x%08x\n", read_fsi(0, 0x003400 | 0x18));

and this hangs, which is probably expected if there are actually no slaves on MFSI of master CPU:

printk(BIOS_EMERG, "read_fsi(1, 0x3418) = 0x%08x\n", read_fsi(1, 0x003400 | 0x18));

Copy link
Contributor

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes required for now, more may come from testing on HW later.

src/soc/ibm/power9/fsi.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/fsi.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/fsi.c Outdated Show resolved Hide resolved
@SergiiDmytruk
Copy link
Member Author

read_fsi(1, 0x003400 | 0x18) still hangs, but it probably should. It tries to access register of MFSI on the second CPU, but we didn't initialize it and maybe won't need to.

I squashed two original commits into one and put fixes into a new one so it's easier to see them during review.

src/soc/ibm/power9/fsi.c Show resolved Hide resolved
src/soc/ibm/power9/fsi.h Show resolved Hide resolved
Change-Id: I8a36fedf7f91f03faa6809da22ed2173932f67e5
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: If646d290ebb599f5f937c97bfea8e73227a33ae3
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants