Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build.sh to be usable as the standard way of building Dasharo coreboot #579

Open
wants to merge 1 commit into
base: dasharo
Choose a base branch
from
Open

Refactor build.sh to be usable as the standard way of building Dasharo coreboot #579

wants to merge 1 commit into from

Conversation

philipandag
Copy link
Contributor

No description provided.

@philipandag
build.sh: Move common build steps to functions
ae120f4 
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
mkopec
mkopec reviewed Nov 12, 2024
View reviewed changes
build.sh
echo -e "\tnv4x_tgl - build Dasharo for Novacustom NV4x 11 gen"

echo "Used environmental variables:"
echo -e "\tCB_REVISION - build Dasharo coreboot from a given revision name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be in this script, if it only checks out a specific rev. For example what happens if it checks out to a revision that doesn't have this script? It may stay in memory and finish the run, but after it finishes the build.sh script may be different and not work the same way if someone calls it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkopec mkopec mkopec left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipandag @mkopec